Skip to content

Implement Android Interstitial Ads - #23

Open
singhaditya21 wants to merge 1 commit into
mainfrom
android-interstitial-ads-5800020974404638611
Open

Implement Android Interstitial Ads#23
singhaditya21 wants to merge 1 commit into
mainfrom
android-interstitial-ads-5800020974404638611

Conversation

@singhaditya21

@singhaditya21 singhaditya21 commented Feb 26, 2026

Copy link
Copy Markdown
Owner

This PR implements real interstitial ad loading logic in the Android application, replacing the mock implementation. It adds the Google Mobile Ads SDK dependency, configures the Manifest with the test App ID, and updates AdManager to load and show interstitial ads correctly, handling callbacks and state management.

PR created automatically by Jules for task 5800020974404638611 started by @singhaditya21

@google-labs-jules @singhaditya21
Implement real interstitial ad loading in Android app.
3829497 
- Add `play-services-ads:23.0.0` dependency to `android/app/build.gradle`.
- Add AdMob App ID to `android/app/src/main/AndroidManifest.xml`.
- Implement `loadInterstitial` and `showInterstitial` in `AdManager.kt` using Google Mobile Ads SDK.
- Fix state management logic to prevent ad reuse and handle preloading.

Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
@google-labs-jules

google-labs-jules Bot commented Feb 26, 2026

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@singhaditya21 singhaditya21 mentioned this pull request Jul 31, 2026
Closed
@singhaditya21

singhaditya21 commented Jul 31, 2026

Copy link
Copy Markdown
Owner Author

Leaving this open rather than merging, for two reasons worth recording.

The Android app cannot currently be built. android/gradle/wrapper/gradle-wrapper.jar is absent from the repo — not gitignored, just never committed — so ./gradlew fails from a fresh clone. Until that is regenerated (cd android && gradle wrapper --gradle-version 8.13) there is no way to compile or test this change, and CI has no Android job either. Merging unverifiable platform code into main is not worth the risk while the backend work is landing there.

Everything else in this triage pass was either applied to main with tests or closed with a reason; these Android PRs are the one group blocked on tooling rather than on review.

@singhaditya21

singhaditya21 commented Jul 31, 2026

Copy link
Copy Markdown
Owner Author

One more thing to settle before this lands: it wires in ca-app-pub-3940256099942544~3347511713, which is Google's public test AdMob app ID. That is correct for development but must be swapped for a real one before release, or the app ships showing test ads.

Worth deciding explicitly too whether ads belong alongside a $4.99/month subscription at all — BannerAdView already takes an isPremium flag, so the intent seems to be free-tier-only, but that is a product call rather than a code one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@singhaditya21